[Opm] Who sets MODULE_ROOT when he/she calls CMake?

[Alf Birger Rustad]

Personally I have never used OPM_COMMON_ROOT, so I am not sure exactly what it does. Hence, there may be some functionality here I am unaware of. With that disclaimer, is it not better to just use opm_common_DIR directly instead? It is a standard location variable (independent of OPM) with predictable behaviour well documented on the net, and for all I know achieves exactly the same. On the positive side, removing OPM_COMMON_ROOT will simplify our cmake set-up significantly, and hopefully make it more intuitive for us all.


Cheers,

Alf

________________________________
Fra: Opm <opm-bounces at opm-project.org> på vegne av Atgeirr Rasmussen <Atgeirr.Rasmussen at sintef.no>
Sendt: 15. september 2017 14:25
Til: OPM Mailing List
Emne: Re: [Opm] Who sets MODULE_ROOT when he/she calls CMake?


15. sep. 2017 kl. 13.44 skrev Markus Blatt <markus at dr-blatt.de<mailto:markus at dr-blatt.de>>:

Hi,

does anyone really pass MODULE_ROOT (OPM_CORE_ROOT, OPM_MATERIAL_ROOT,
etc.) to CMake to tell it where the modules are located?


I do. This is from my CMake options file (that I use by "cmake -C options.cmake <source location>" for each module).

set(OPM_COMMON_ROOT "/Users/atgeirr/opm/opm-common" CACHE STRING "OPM build system")
# set(DUNE_ROOT "/Users/atgeirr/dune" CACHE STRING "Dune core modules")

I do not remember why I used to need Dune and now don't, and I am not 100% sure the OPM_COMMON_ROOT is necessary either, but I have not changed this setup in a long while…

Do you want to remove this for some reason? I'm willing to test things and change my setup if necessary (as long as we always have something that works).

Atgeirr



-------------------------------------------------------------------
The information contained in this message may be CONFIDENTIAL and is
intended for the addressee only. Any unauthorized use, dissemination of the
information or copying of this message is prohibited. If you are not the
addressee, please notify the sender immediately by return e-mail and delete
this message.
Thank you
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <//opm-project.org/pipermail/opm/attachments/20170916/0ebb4870/attachment.html>